Bug 145068

Summary:

Web Inspector: Fix some possible event listener leakers in content views

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-05-15 12:35:07 PDT

* SUMMARY
Fix some possible event listener leakers in content views.

Now that tabs and their content views can be closed, sometimes some ContentViews which always existed can be closed.

Global event listeners like "WebInspector.*.addEventListener" and "window.addEventListener" should be cleaned up.

Comment 1 Joseph Pecoraro 2015-05-15 12:36:16 PDT

Created attachment 253217 [details]
[PATCH] Proposed Fix

Comment 2 Timothy Hatcher 2015-05-15 12:58:32 PDT

Comment on attachment 253217 [details]
[PATCH] Proposed Fix

Awesome!

Comment 3 WebKit Commit Bot 2015-05-15 13:48:38 PDT

Comment on attachment 253217 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253217

Committed r184411: <http://trac.webkit.org/changeset/184411>

Comment 4 WebKit Commit Bot 2015-05-15 13:48:43 PDT

All reviewed patches have been landed.  Closing bug.