Bug 145068 - Web Inspector: Fix some possible event listener leakers in content views
Summary: Web Inspector: Fix some possible event listener leakers in content views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-05-15 12:35 PDT by Joseph Pecoraro
Modified: 2015-05-15 13:48 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (10.52 KB, patch)
2015-05-15 12:36 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-05-15 12:35:07 PDT 
* SUMMARY
Fix some possible event listener leakers in content views.

Now that tabs and their content views can be closed, sometimes some ContentViews which always existed can be closed.

Global event listeners like "WebInspector.*.addEventListener" and "window.addEventListener" should be cleaned up.
Comment 1 Joseph Pecoraro 2015-05-15 12:36:16 PDT 
Created attachment 253217 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2015-05-15 12:58:32 PDT 
Comment on attachment 253217 [details]
[PATCH] Proposed Fix

Awesome!
Comment 3 WebKit Commit Bot 2015-05-15 13:48:38 PDT 
Comment on attachment 253217 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253217

Committed r184411: <http://trac.webkit.org/changeset/184411>
Comment 4 WebKit Commit Bot 2015-05-15 13:48:43 PDT 
All reviewed patches have been landed.  Closing bug.