Bug 145067

Summary:

Web Inspector: Initiator Popovers no longer work in Layout Timeline

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-05-15 12:30:56 PDT

* SUMMARY
Initiator Popovers no longer work in Layout Timeline.

The anchor finder is returning null:

    callFramePopoverAnchorElement: function()
    {
        return this.selectedNode.elementWithColumnIdentifier("initiatorCallFrame");
    }

Because "initiatorCallFrame" changed to "location".

There was a console.assert that caught this.

Comment 1 Joseph Pecoraro 2015-05-15 12:32:20 PDT

Created attachment 253216 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2015-05-15 13:47:41 PDT

Comment on attachment 253216 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253216

Committed r184410: <http://trac.webkit.org/changeset/184410>

Comment 3 WebKit Commit Bot 2015-05-15 13:47:45 PDT

All reviewed patches have been landed.  Closing bug.