Bug 145063

Summary: AudioContext should resolve promises with jsUndefined() and not jsNull()
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, jer.noble, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2015-05-15 11:35:14 PDT
AudioContext resume, suspend and close are all returning promises. Resolving these promises is done by passing a null value, while there should be no value passed at all, therefore passing undefined.
Attachments
Patch (3.55 KB, patch)
2015-05-15 12:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-05-15 12:01:01 PDT
Created attachment 253212 [details] Patch
Jer Noble
Comment 2 2015-05-15 13:21:47 PDT
What do other browsers do for Promise<void>?
youenn fablet
Comment 3 2015-05-15 13:45:30 PDT
Chromium is going the undefined way. Not sure about Mozilla and IE.
youenn fablet
Comment 4 2015-05-15 13:46:31 PDT
(In reply to comment #3) > Chromium is going the undefined way. > Not sure about Mozilla and IE. Also, in the streams API, we are going with undefined as well when resolving the close promise.
Darin Adler
Comment 5 2015-05-19 08:39:06 PDT
Sam, can you make the call on this?
Sam Weinig
Comment 6 2015-05-19 12:58:26 PDT
Comment on attachment 253212 [details] Patch Seems fine. r=me.
WebKit Commit Bot
Comment 7 2015-05-19 14:12:28 PDT
Comment on attachment 253212 [details] Patch Clearing flags on attachment: 253212 Committed r184588: <http://trac.webkit.org/changeset/184588>
WebKit Commit Bot
Comment 8 2015-05-19 14:12:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.