Bug 145041

Summary: AX: Select text mechanism returns results outside of text control regions
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch mario: review+

Description chris fleizach 2015-05-14 23:54:25 PDT
INSTRUCTIONS:
1. Enable Enhanced Dictation in System Preferences>Dictation & Speech
2. Enable Advanced Commands in System Preferences>Accessibility>Dictation>Dictation Commands
3. Open Safari and go to LinkedIn.com
4. Place cursor in search area and activate dictation with fn-fn.
5. Say "The quick brown fox"
6. Say "Show commands window"
7. Randomly select and say navigation and selection commands


This is because the select-text mechanism should only return results within a text control when the search is within a text control
Comment 1 Radar WebKit Bug Importer 2015-05-14 23:54:41 PDT
<rdar://problem/20970909>
Comment 2 chris fleizach 2015-05-14 23:58:10 PDT
<rdar://problem/18181921>
Comment 3 chris fleizach 2015-05-15 00:03:23 PDT
Created attachment 253179 [details]
patch
Comment 4 Mario Sanchez Prada 2015-05-18 03:19:01 PDT
Comment on attachment 253179 [details]
patch

The bug title was a bit misleading to me at the beginning, since it says "editable text area regions" while the patch is specific to text controls in forms.

After reviewing the patch, I think it makes sense to limit this to text controls and not to all editable text regions (e.g. contenteditable="true"), as you don't normally want to mix/merge the text from inside those controls with the text from the rest of the page. But perhaps changing the bug title and updating the changelog before landing could be a nice thing to do too, if it's not too much of a trouble.
Comment 5 chris fleizach 2015-05-19 08:48:44 PDT
Thanks

http://trac.webkit.org/changeset/184563