Bug 145037

Summary: Have DOMWindow::createWindow() take references to frames
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-05-14 20:47:02 PDT 
Have DOMWindow::createWindow() take references to frames instead of pointers as they are expected to be non-null. Also return a RefPtr instead of a PassRefPtr.
Comment 1 Chris Dumez 2015-05-14 20:49:09 PDT 
Created attachment 253173 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-14 20:50:50 PDT 
Attachment 253173 [details] did not pass style-queue:


ERROR: Source/WebCore/page/DOMWindow.h:356:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2075:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2015-05-14 21:17:19 PDT 
Comment on attachment 253173 [details]
Patch

LGTM.
Comment 4 WebKit Commit Bot 2015-05-14 22:08:53 PDT 
Comment on attachment 253173 [details]
Patch

Clearing flags on attachment: 253173

Committed r184372: <http://trac.webkit.org/changeset/184372>
Comment 5 WebKit Commit Bot 2015-05-14 22:08:57 PDT 
All reviewed patches have been landed.  Closing bug.