Bug 145037 - Have DOMWindow::createWindow() take references to frames
Summary: Have DOMWindow::createWindow() take references to frames
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-14 20:47 PDT by Chris Dumez
Modified: 2015-05-14 22:08 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.12 KB, patch)
2015-05-14 20:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-05-14 20:47:02 PDT
Have DOMWindow::createWindow() take references to frames instead of pointers as they are expected to be non-null. Also return a RefPtr instead of a PassRefPtr.
Comment 1 Chris Dumez 2015-05-14 20:49:09 PDT
Created attachment 253173 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-14 20:50:50 PDT
Attachment 253173 [details] did not pass style-queue:


ERROR: Source/WebCore/page/DOMWindow.h:356:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/DOMWindow.cpp:2075:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2015-05-14 21:17:19 PDT
Comment on attachment 253173 [details]
Patch

LGTM.
Comment 4 WebKit Commit Bot 2015-05-14 22:08:53 PDT
Comment on attachment 253173 [details]
Patch

Clearing flags on attachment: 253173

Committed r184372: <http://trac.webkit.org/changeset/184372>
Comment 5 WebKit Commit Bot 2015-05-14 22:08:57 PDT
All reviewed patches have been landed.  Closing bug.