| Summary: | Add a layout mode that scales down the view to try to fit the document | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, dino, mitz, sam, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-05-14 15:11:10 PDT
Created attachment 253149 [details]
Patch
Comment on attachment 253149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253149&action=review > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:278 > + const int maximumDocumentWidthForScaling = 1440; > + const float minimumViewScale = 0.1; Aren't these defined elsewhere? > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:304 > + viewScale = (float)viewWidth / (float)documentWidth; Can documentWidth ever be zero? (In reply to comment #2) > Comment on attachment 253149 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253149&action=review > > > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:278 > > + const int maximumDocumentWidthForScaling = 1440; > > + const float minimumViewScale = 0.1; > > Aren't these defined elsewhere? Not for this mechanism, no. > > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:304 > > + viewScale = (float)viewWidth / (float)documentWidth; > > Can documentWidth ever be zero? Probably. We should probably not even try to do anything in that case. Will fix. Thanks! |