Bug 145017

Summary:

Local storage origins should include origins with transient local storage

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2015-05-14 13:32:34 PDT

Local storage origins should include origins with transient local storage

Comment 1 Anders Carlsson 2015-05-14 13:33:58 PDT

Created attachment 253141 [details]
Patch

Comment 2 WebKit Commit Bot 2015-05-14 13:37:04 PDT

Attachment 253141 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:62:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:529:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Sam Weinig 2015-05-14 14:39:02 PDT

Comment on attachment 253141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253141&action=review

> Source/WebKit2/ChangeLog:5
> +        Local storage origins should include origins with transient local storage
> +        https://bugs.webkit.org/show_bug.cgi?id=145017
> +        rdar://problem/10690447

I think this needs a clearer explanation.  I assume this is transient local storage that is due to portioning, rather than private browsing mode.

Comment 4 Anders Carlsson 2015-05-14 14:44:56 PDT

Committed r184356: <http://trac.webkit.org/changeset/184356>