Bug 145009

Summary:

Support blocking a plug-in for non-security reasons

Product:

WebKit

Reporter:

Jessie Berlin <jberlin>

Component:

Plug-ins

Assignee:

Gordon Sheridan <gordon_sheridan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, conrad_shultz, dbates, gordon_sheridan, jberlin, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
This patch adds plumbing for supporting the ability to block plugins for non-security reasons.	none
Add plumbing for the ability to block plugins for non-security reasons	none
WKSI support for blocking a plug-in for non-security reasons.	none
WKSI support for blocking a plug-in for non-security reasons. (Take 2)	none
WKSI support for blocking a plug-in for non-security reasons. (Take 3)	none
WKSI support for blocking a plug-in for non-security reasons. (Take 4)	none
WKSI support for blocking a plug-in for non-security reasons. (Take 5)	none
WKSI support for blocking a plug-in for non-security reasons. (Take 6)	none
WebKit support for blocking a plugin-in for non-security reasons.	andersca: review+, andersca: commit-queue+

Jessie Berlin

Reported 2015-05-14 09:54:53 PDT

rdar://problem/20860410

Attachments
Patch (8.69 KB, patch) 2015-05-14 10:54 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
This patch adds plumbing for supporting the ability to block plugins for non-security reasons. (8.28 KB, patch) 2015-07-15 00:46 PDT, Alan Sien Wei Hshieh	no flags	Details Formatted Diff Diff
Add plumbing for the ability to block plugins for non-security reasons (8.28 KB, patch) 2015-07-15 02:25 PDT, Alan Sien Wei Hshieh	no flags	Details Formatted Diff Diff
WKSI support for blocking a plug-in for non-security reasons. (342.77 KB, patch) 2015-07-17 19:40 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
WKSI support for blocking a plug-in for non-security reasons. (Take 2) (342.77 KB, patch) 2015-07-17 19:48 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
WKSI support for blocking a plug-in for non-security reasons. (Take 3) (25.71 KB, patch) 2015-07-17 19:58 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
WKSI support for blocking a plug-in for non-security reasons. (Take 4) (342.78 KB, patch) 2015-07-17 20:03 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
WKSI support for blocking a plug-in for non-security reasons. (Take 5) (341.99 KB, patch) 2015-07-17 20:11 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
WKSI support for blocking a plug-in for non-security reasons. (Take 6) (341.79 KB, patch) 2015-07-20 12:24 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
WebKit support for blocking a plugin-in for non-security reasons. (10.76 KB, patch) 2015-07-20 14:59 PDT, Gordon Sheridan	andersca: review+ andersca: commit-queue+	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Gordon Sheridan

Comment 1 2015-05-14 10:54:41 PDT

Created attachment 253128 [details] Patch

Darin Adler

Comment 2 2015-05-17 11:05:43 PDT

Comment on attachment 253128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253128&action=review Does this patch require a change to WebKitSystemInterface? > Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:114 > + return toPluginModuleLoadPolicy(WKLoadPolicyForPluginVersion(plugin.bundleIdentifier, plugin.versionString)); Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:114:37: error: use of undeclared identifier 'WKLoadPolicyForPluginVersion' return toPluginModuleLoadPolicy(WKLoadPolicyForPluginVersion(plugin.bundleIdentifier, plugin.versionString));

Alan Sien Wei Hshieh

Comment 3 2015-07-15 00:46:28 PDT

Created attachment 256829 [details] This patch adds plumbing for supporting the ability to block plugins for non-security reasons. I'm submitting this patch on behalf of Gordon Sheridan, since responsibility for related work was transferred to me. This is intended to obsolete his previous attachment ~2 months ago since we have made a change to WKSI.

Alan Sien Wei Hshieh

Comment 4 2015-07-15 02:25:35 PDT

Created attachment 256830 [details] Add plumbing for the ability to block plugins for non-security reasons (Trying this again)

Conrad Shultz

Comment 5 2015-07-15 13:58:09 PDT

I think there's a WKSI change missing... but can we do this without adding new code there?

Gordon Sheridan

Comment 6 2015-07-17 19:40:20 PDT

Created attachment 257017 [details] WKSI support for blocking a plug-in for non-security reasons.

Gordon Sheridan

Comment 7 2015-07-17 19:48:07 PDT

Created attachment 257018 [details] WKSI support for blocking a plug-in for non-security reasons. (Take 2)

Gordon Sheridan

Comment 8 2015-07-17 19:58:17 PDT

Created attachment 257019 [details] WKSI support for blocking a plug-in for non-security reasons. (Take 3)

Gordon Sheridan

Comment 9 2015-07-17 20:03:21 PDT

Created attachment 257020 [details] WKSI support for blocking a plug-in for non-security reasons. (Take 4)

Gordon Sheridan

Comment 10 2015-07-17 20:11:31 PDT

Created attachment 257021 [details] WKSI support for blocking a plug-in for non-security reasons. (Take 5)

WebKit Commit Bot

Comment 11 2015-07-17 20:14:20 PDT

Attachment 257021 [details] did not pass style-queue: ERROR: WebKitLibraries/WebKitSystemInterface.h:57: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:73: The parameter name "cgContext" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:96: The parameter name "font" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:96: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:104: The parameter name "image" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:104: The parameter name "transform" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:107: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:108: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:138: The parameter name "port" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:147: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:147: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:160: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:183: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:184: The parameter name "sandboxExtension" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:186: The parameter name "sandboxExtension" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:187: The parameter name "sandboxExtension" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:189: The parameter name "sandboxExtension" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:194: The parameter name "path" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:194: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:423: The parameter name "subsystem" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:441: The parameter name "eventRef" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:442: The parameter name "window" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: WebKitLibraries/WebKitSystemInterface.h:443: The parameter name "windowRef" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 24 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gordon Sheridan

Comment 12 2015-07-20 12:24:16 PDT

Created attachment 257117 [details] WKSI support for blocking a plug-in for non-security reasons. (Take 6)

WebKit Commit Bot

Comment 13 2015-07-20 14:49:24 PDT

Comment on attachment 257117 [details] WKSI support for blocking a plug-in for non-security reasons. (Take 6) Clearing flags on attachment: 257117 Committed r187038: <http://trac.webkit.org/changeset/187038>

WebKit Commit Bot

Comment 14 2015-07-20 14:49:28 PDT

All reviewed patches have been landed. Closing bug.

Gordon Sheridan

Comment 15 2015-07-20 14:59:52 PDT

Created attachment 257130 [details] WebKit support for blocking a plugin-in for non-security reasons.

Gordon Sheridan

Comment 16 2015-07-20 16:36:13 PDT

Reopened bug to take second patch.

Anders Carlsson

Comment 17 2015-07-20 16:46:59 PDT

Committed r187047: <http://trac.webkit.org/changeset/187047>

Note You need to log in before you can comment on or make changes to this bug.