Bug 144988

Summary:

[GTK] ar warning when linking static libraries

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mcatanzaro, mrobinson, pnormand, zan

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Carlos Garcia Campos 2015-05-13 23:11:34 PDT

Linking CXX static library lib/libbmalloc.a
/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')

It started to happen recently, probably because I upgraded binutils and this warning is new, and it happens for every static library we build. I have no idea what it means, bu in this redhat bug it's suggested to use either cr or crUu instead of cru as we currently use (and T also).

Comment 1 Carlos Garcia Campos 2015-05-13 23:12:05 PDT

Forgot the link to the rh bz, https://bugzilla.redhat.com/show_bug.cgi?id=1155273

Comment 2 Michael Catanzaro 2015-07-09 17:40:40 PDT

See also: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20082

Comment 3 Michael Catanzaro 2015-07-09 18:14:11 PDT

Created attachment 256550 [details]
Patch

Comment 4 Michael Catanzaro 2015-07-09 18:16:50 PDT

Created attachment 256551 [details]
Patch

Comment 5 Carlos Garcia Campos 2015-07-09 23:15:07 PDT

Comment on attachment 256551 [details]
Patch

Ok, sounds reasonable. Thanks!

Comment 6 Philippe Normand 2015-07-10 00:12:39 PDT

Comment on attachment 256551 [details]
Patch

Shouldn't we check the binutils version before removing the 'u'?

Comment 7 Michael Catanzaro 2015-07-10 05:13:39 PDT

(In reply to comment #6)
> Comment on attachment 256551 [details]
> Patch
> 
> Shouldn't we check the binutils version before removing the 'u'?

I don't think so, since the issue is only slightly related to binutils version. What matters is whether the distro has decided to use deterministic builds by default or not. If we could find a way to check that, then we could use it determine whether or not to use u, but I don't think anybody else plans to do that, and there's not much point; I'd rather just remove 'u'. Also, since we use 'T' for thin archives, I doubt there's much any benefit to 'u' (but I haven't measured).

Comment 8 WebKit Commit Bot 2015-07-10 05:34:25 PDT

Comment on attachment 256551 [details]
Patch

Clearing flags on attachment: 256551

Committed r186670: <http://trac.webkit.org/changeset/186670>

Comment 9 WebKit Commit Bot 2015-07-10 05:34:31 PDT

All reviewed patches have been landed.  Closing bug.