Bug 144976

Summary: [ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and not negative zero
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2015-05-13 17:38:43 PDT
[ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and not negative zero
Attachments
Patch (2.53 KB, patch)
2015-05-13 17:43 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2015-05-14 19:17 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-05-13 17:43:09 PDT
Created attachment 253077 [details] Patch
Michael Saboff
Comment 2 2015-05-13 17:48:50 PDT
Comment on attachment 253077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253077&action=review Needs a little more work I think > Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:1212 > + Jump valueIsNonZero = branchTest32(NonZero, dest); You don't have anything in dest yet to make this comparison.
Benjamin Poulain
Comment 3 2015-05-14 19:17:14 PDT
Created attachment 253167 [details] Patch
Michael Saboff
Comment 4 2015-05-14 21:10:00 PDT
Comment on attachment 253167 [details] Patch r=me
Benjamin Poulain
Comment 5 2015-05-15 14:11:38 PDT
Comment on attachment 253167 [details] Patch Clearing flags on attachment: 253167 Committed r184414: <http://trac.webkit.org/changeset/184414>
Benjamin Poulain
Comment 6 2015-05-15 14:11:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.