Bug 144976 - [ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and not negative zero
Summary: [ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-13 17:38 PDT by Benjamin Poulain
Modified: 2015-05-15 14:11 PDT (History)
0 users

See Also:

Attachments
Patch (2.53 KB, patch)
2015-05-13 17:43 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2015-05-14 19:17 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-05-13 17:38:43 PDT 
[ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and not negative zero
Comment 1 Benjamin Poulain 2015-05-13 17:43:09 PDT 
Created attachment 253077 [details]
Patch
Comment 2 Michael Saboff 2015-05-13 17:48:50 PDT 
Comment on attachment 253077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253077&action=review

Needs a little more work I think

> Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:1212
> +            Jump valueIsNonZero = branchTest32(NonZero, dest);

You don't have anything in dest yet to make this comparison.
Comment 3 Benjamin Poulain 2015-05-14 19:17:14 PDT 
Created attachment 253167 [details]
Patch
Comment 4 Michael Saboff 2015-05-14 21:10:00 PDT 
Comment on attachment 253167 [details]
Patch

r=me
Comment 5 Benjamin Poulain 2015-05-15 14:11:38 PDT 
Comment on attachment 253167 [details]
Patch

Clearing flags on attachment: 253167

Committed r184414: <http://trac.webkit.org/changeset/184414>
Comment 6 Benjamin Poulain 2015-05-15 14:11:45 PDT 
All reviewed patches have been landed.  Closing bug.