Bug 144972

Summary:

[SOUP] Assert when main resource handle is converted to download in network process

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

cgarcia, mcatanzaro

Priority:

Keywords:

Soup

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

See Also:

https://bugzilla.redhat.com/show_bug.cgi?id=1221373

Attachments:

Description	Flags
backtrace of assertion	none

Michael Catanzaro

Reported 2015-05-13 14:34:54 PDT

After updating from 2.8.1 to 2.8.2, I can no longer download files.

Attachments
backtrace of assertion (59.15 KB, text/plain) 2015-05-13 16:53 PDT, Michael Catanzaro	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2015-05-13 16:53:17 PDT

Created attachment 253074 [details] backtrace of assertion My debug build of 2.8.2 is hitting an assertion in the network process. Note: If it matters, I tried to download the webkitgtk-2.8.2 tarball from webkitgtk.org.

Michael Catanzaro

Comment 2 2015-05-13 19:46:39 PDT

There were six backports that touched networking code: https://trac.webkit.org/changeset/184079/releases/WebKitGTK/webkit-2.8 https://trac.webkit.org/changeset/184080/releases/WebKitGTK/webkit-2.8 https://trac.webkit.org/changeset/184086/releases/WebKitGTK/webkit-2.8 https://trac.webkit.org/changeset/184096/releases/WebKitGTK/webkit-2.8 https://trac.webkit.org/changeset/184099/releases/WebKitGTK/webkit-2.8 https://trac.webkit.org/changeset/184175/releases/WebKitGTK/webkit-2.8

Carlos Garcia Campos

Comment 3 2015-05-13 22:56:59 PDT

Interesting, this probably means I merged the commit that broke it in trunk :-)

Carlos Garcia Campos

Comment 4 2015-05-14 00:09:34 PDT

This is actually a duplicate of bug #144738, but the backtrace showed another problem. When converting a handle to a download, we assert in ResourceHandle::continueDidReceiveResponse(), because the download client doesn't use async callbacks.

Carlos Garcia Campos

Comment 5 2015-05-15 01:45:35 PDT

Fixed in r184376: <http://trac.webkit.org/changeset/184376>

Note You need to log in before you can comment on or make changes to this bug.