Bug 144972

Summary: [SOUP] Assert when main resource handle is converted to download in network process
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: cgarcia, mcatanzaro
Priority: P2 Keywords: Soup
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=1221373
Attachments:
Description Flags
backtrace of assertion none

Description Michael Catanzaro 2015-05-13 14:34:54 PDT
After updating from 2.8.1 to 2.8.2, I can no longer download files.
Comment 1 Michael Catanzaro 2015-05-13 16:53:17 PDT
Created attachment 253074 [details]
backtrace of assertion

My debug build of 2.8.2 is hitting an assertion in the network process.

Note: If it matters, I tried to download the webkitgtk-2.8.2 tarball from webkitgtk.org.
Comment 3 Carlos Garcia Campos 2015-05-13 22:56:59 PDT
Interesting, this probably means I merged the commit that broke it in trunk :-)
Comment 4 Carlos Garcia Campos 2015-05-14 00:09:34 PDT
This is actually a duplicate of bug #144738, but the backtrace showed another problem. When converting a handle to a download, we assert in ResourceHandle::continueDidReceiveResponse(), because the download client doesn't use async callbacks.
Comment 5 Carlos Garcia Campos 2015-05-15 01:45:35 PDT
Fixed in r184376: <http://trac.webkit.org/changeset/184376>