Bug 144959 – [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Michael Catanzaro]

In https://bugs.webkit.org/show_bug.cgi?id=144747#c5

check-webkit-style claims:

ERROR: Source/WebKit2/PlatformGTK.cmake:491:  Alphabetical sorting problem. "PluginProcess/PluginControllerProxy.cpp" should be before "PluginProcess/EntryPoint/unix/PluginProcessMain.cpp".  [list/order] [5]

There really is an alphabetical sorting problem on line 491:

list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
    ${WTF_DIR}
    ${CAIRO_INCLUDE_DIRS}

But I have no clue where PluginProcess/PluginControllerProxy.cpp and PluginProcess/EntryPoint/unix/PluginProcessMain.cpp are coming from. Those have nothing to do with this.

[Carlos Alberto Lopez Perez]

Also on https://bugs.webkit.org/show_bug.cgi?id=145408#c9

It complains about an alphabetical sorting error on Source/WebCore/PlatformEfl.cmake.

While this error is true, it was not caused by my patch. It was already there and my patch don't touches any line near it. So it shouldn't complain about something unrelated with the patch.

[Csaba Osztrogonác]

$ Tools/Scripts/check-webkit-style Source/WebCore/PlatformEfl.cmake

ERROR: Source/WebCore/PlatformEfl.cmake:366:  Alphabetical sorting problem. "platform/efl/PlatformSpeechSynthesisProviderEfl.cpp" should be before "platform/efl/PlatformSpeechSynthesizerEfl.cpp".  [list/order] [5]
ERROR: Source/WebCore/PlatformEfl.cmake:378:  There should be exactly one empty line instead of 0 between "crypto/SubtleCrypto.cpp" and "crypto/algorithms/CryptoAlgorithmAES_CBC.cpp".  [list/emptyline] [5]
ERROR: Source/WebCore/PlatformEfl.cmake:383:  Alphabetical sorting problem. "crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp" should be before "crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp".  [list/order] [5]
ERROR: Source/WebCore/PlatformEfl.cmake:391:  Alphabetical sorting problem. "crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp" should be before "crypto/gnutls/CryptoAlgorithmRegistryGnuTLS.cpp".  [list/order] [5]
ERROR: Source/WebCore/PlatformEfl.cmake:396:  Alphabetical sorting problem. "crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp" should be before "crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp".  [list/order] [5]
Total errors found: 5 in 1 files

But these entries aren't in these lines, but
- 484 instead of 366
- 495 instead of 378
- 501 instead of 383
- 509 instead of 391
- 514 instead of 396

The difference is 118 everywhere, I have no idea why.
Let me check it to try to find where the bug is.

[Csaba Osztrogonác]

Created attachment 253999 [details]
Patch

The bug is in _check_list_order, line_number isn't incremented when matched is true. We should use enumerate to avoid this kind of bugs.

[WebKit Commit Bot]

Comment on attachment 253999 [details]
Patch

Clearing flags on attachment: 253999

Committed r185065: <http://trac.webkit.org/changeset/185065>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.