Bug 144950

Summary:

Network Cache: Make Data::adoptMap take the ownership of the file descriptor

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	koivisto: review+
with xcode project file changes	none
with xcode project file changes	none
again with xcode project file changes	none

Carlos Garcia Campos

Reported 2015-05-13 02:01:30 PDT

It will be required to implement ShareableResource for soup network backend. Also move the common code of Data to a common file and add mapToFile.

Attachments
Patch (15.67 KB, patch) 2015-05-13 02:10 PDT, Carlos Garcia Campos	koivisto: review+	Details Formatted Diff Diff
with xcode project file changes (30.70 KB, patch) 2015-05-15 06:33 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
with xcode project file changes (19.14 KB, patch) 2015-05-15 06:34 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
again with xcode project file changes (19.10 KB, patch) 2015-05-15 08:43 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2015-05-13 02:10:37 PDT

Created attachment 253028 [details] Patch This will fail to build in mac, since I need someone with a mac who add the new file to xcode file.

Antti Koivisto

Comment 2 2015-05-15 06:33:00 PDT

Created attachment 253196 [details] with xcode project file changes

Antti Koivisto

Comment 3 2015-05-15 06:34:15 PDT

Created attachment 253197 [details] with xcode project file changes

Antti Koivisto

Comment 4 2015-05-15 08:43:20 PDT

Created attachment 253198 [details] again with xcode project file changes

Carlos Garcia Campos

Comment 5 2015-05-17 23:31:40 PDT

Note You need to log in before you can comment on or make changes to this bug.