Bug 144941

Summary:

[GTK][CMake] Extra include directory when libnotify is present but disabled

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKitGTK

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

commit-queue, mcatanzaro, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Description Michael Catanzaro 2015-05-12 18:54:37 PDT

if (LIBNOTIFY_FOUND)
list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
    ${LIBNOTIFY_INCLUDE_DIRS}
)
endif ()


That should be if (USE_LIBNOTIFY) since we don't want to add the include directory if we're not using it.

Comment 1 Michael Catanzaro 2015-05-13 12:03:05 PDT

Created attachment 253041 [details]
Patch

Comment 2 Martin Robinson 2015-05-13 12:10:16 PDT

Comment on attachment 253041 [details]
Patch

Ugh. Thanks.

Comment 3 WebKit Commit Bot 2015-05-13 12:57:58 PDT

Comment on attachment 253041 [details]
Patch

Clearing flags on attachment: 253041

Committed r184298: <http://trac.webkit.org/changeset/184298>

Comment 4 WebKit Commit Bot 2015-05-13 12:58:00 PDT

All reviewed patches have been landed.  Closing bug.