WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144941
[GTK][CMake] Extra include directory when libnotify is present but disabled
https://bugs.webkit.org/show_bug.cgi?id=144941
Summary
[GTK][CMake] Extra include directory when libnotify is present but disabled
Michael Catanzaro
Reported
2015-05-12 18:54:37 PDT
if (LIBNOTIFY_FOUND) list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES ${LIBNOTIFY_INCLUDE_DIRS} ) endif () That should be if (USE_LIBNOTIFY) since we don't want to add the include directory if we're not using it.
Attachments
Patch
(1.26 KB, patch)
2015-05-13 12:03 PDT
,
Michael Catanzaro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2015-05-13 12:03:05 PDT
Created
attachment 253041
[details]
Patch
Martin Robinson
Comment 2
2015-05-13 12:10:16 PDT
Comment on
attachment 253041
[details]
Patch Ugh. Thanks.
WebKit Commit Bot
Comment 3
2015-05-13 12:57:58 PDT
Comment on
attachment 253041
[details]
Patch Clearing flags on attachment: 253041 Committed
r184298
: <
http://trac.webkit.org/changeset/184298
>
WebKit Commit Bot
Comment 4
2015-05-13 12:58:00 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug