Bug 144933

Summary: com.apple.WebKit.WebContent crashed at JavaScriptCore: JSC::CodeBlock::finalizeUnconditionally
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Updated patch with release build fix and ChangeLog fix ggaren: review+

Michael Saboff
Reported 2015-05-12 15:54:48 PDT
There are occasional crashes due to the RELEASE_ASSERT_NOT_REACHED in CodeBlock::finalizeUnconditionally. It is probably better to change this to an ASSERT, as the RELEASE ASSERT is probably worse than what it is trying to protect. rdar://problem/18717477
Attachments
Patch (1.55 KB, patch)
2015-05-12 15:59 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated patch with release build fix and ChangeLog fix (1.56 KB, patch)
2015-05-12 21:07 PDT, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2015-05-12 15:59:40 PDT
Created attachment 252995 [details] Patch
Mark Lam
Comment 2 2015-05-12 17:56:42 PDT
Comment on attachment 252995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252995&action=review > Source/JavaScriptCore/ChangeLog:7 > + determine the help determine the cause for any crash. extra “determine the”.
Michael Saboff
Comment 3 2015-05-12 21:07:19 PDT
Created attachment 253014 [details] Updated patch with release build fix and ChangeLog fix
Geoffrey Garen
Comment 4 2015-05-13 10:24:01 PDT
Comment on attachment 253014 [details] Updated patch with release build fix and ChangeLog fix r=me
Michael Saboff
Comment 5 2015-05-13 11:00:23 PDT
Committed r184289: <http://trac.webkit.org/changeset/184289>
Note You need to log in before you can comment on or make changes to this bug.