Bug 144933

Summary: com.apple.WebKit.WebContent crashed at JavaScriptCore: JSC::CodeBlock::finalizeUnconditionally
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Updated patch with release build fix and ChangeLog fix ggaren: review+

Description Michael Saboff 2015-05-12 15:54:48 PDT 
There are occasional crashes due to the RELEASE_ASSERT_NOT_REACHED in CodeBlock::finalizeUnconditionally.
It is probably better to change this to an ASSERT, as the RELEASE ASSERT is probably worse than what it is trying to protect.

rdar://problem/18717477
Comment 1 Michael Saboff 2015-05-12 15:59:40 PDT 
Created attachment 252995 [details]
Patch
Comment 2 Mark Lam 2015-05-12 17:56:42 PDT 
Comment on attachment 252995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252995&action=review

> Source/JavaScriptCore/ChangeLog:7
> +        determine the help determine the cause for any crash.

extra “determine the”.
Comment 3 Michael Saboff 2015-05-12 21:07:19 PDT 
Created attachment 253014 [details]
Updated patch with release build fix and ChangeLog fix
Comment 4 Geoffrey Garen 2015-05-13 10:24:01 PDT 
Comment on attachment 253014 [details]
Updated patch with release build fix and ChangeLog fix

r=me
Comment 5 Michael Saboff 2015-05-13 11:00:23 PDT 
Committed r184289: <http://trac.webkit.org/changeset/184289>