Bug 144931

Summary: If JSC cannot get executable memory, it shouldn't call madvise
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mark.lam: review+

Michael Saboff
Reported 2015-05-12 14:58:07 PDT
If the mmap in OSAllocator::reserveAndCommit() fails, we shouldn't madvise(0, ...) in OSAllocator::reserveUncommitted(). This will likely adversely affect the application. rdar://problem/19611967 rdar://problem/20733907
Attachments
Patch (1.46 KB, patch)
2015-05-12 15:02 PDT, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2015-05-12 15:02:57 PDT
Created attachment 252988 [details] Patch
Mark Lam
Comment 2 2015-05-12 17:55:23 PDT
Comment on attachment 252988 [details] Patch r=me
Michael Saboff
Comment 3 2015-05-12 21:03:34 PDT
Committed r184245: <http://trac.webkit.org/changeset/184245>
Note You need to log in before you can comment on or make changes to this bug.