Bug 144931

Summary:

If JSC cannot get executable memory, it shouldn't call madvise

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	mark.lam: review+

Description Michael Saboff 2015-05-12 14:58:07 PDT

If the mmap in OSAllocator::reserveAndCommit() fails, we shouldn't madvise(0, ...) in OSAllocator::reserveUncommitted().  This will likely adversely affect the application.

rdar://problem/19611967
rdar://problem/20733907

Comment 1 Michael Saboff 2015-05-12 15:02:57 PDT

Created attachment 252988 [details]
Patch

Comment 2 Mark Lam 2015-05-12 17:55:23 PDT

Comment on attachment 252988 [details]
Patch

r=me

Comment 3 Michael Saboff 2015-05-12 21:03:34 PDT

Committed r184245: <http://trac.webkit.org/changeset/184245>