Bug 144928 – Need SPI to set the overlay scroll bar style

• Component: WebKit2
• Status: RESOLVED FIXED

[Beth Dakin]

Need SPI to set the overlay scroll bar style

rdar://problem/20143614

[Beth Dakin]

Created attachment 252984 [details]
Patch

[WebKit Commit Bot]

Attachment 252984 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:4472:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 252984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252984&action=review

> Source/WebCore/platform/ScrollTypes.h:167
>      enum ScrollbarOverlayStyle {
>          ScrollbarOverlayStyleDefault,
>          ScrollbarOverlayStyleDark,
> -        ScrollbarOverlayStyleLight
> +        ScrollbarOverlayStyleLight,
> +        ScrollbarOverlayStyleNone

I'm surprised this isn't OverlayScrollbarStyle? It's the style of the overlay scrollbar, not the overlay style of the scrollbar.

> Source/WebKit2/UIProcess/API/Cocoa/_WKOverlayScrollbarStyle.h:37
> +    _WKOverlayScrollbarStyleNone

Automatic?

[Beth Dakin]

Created attachment 252997 [details]
Patch

[Anders Carlsson]

Comment on attachment 252997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252997&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:5006
> +        parameters.scrollbarOverlayStyle = WTF::Optional<uint32_t>();

= Nullopt.

[Beth Dakin]

Thank you! http://trac.webkit.org/changeset/184297

[Beth Dakin]

Follow-up build fix: http://trac.webkit.org/changeset/184299