Bug 144928 - Need SPI to set the overlay scroll bar style
Summary: Need SPI to set the overlay scroll bar style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-12 14:08 PDT by Beth Dakin
Modified: 2015-05-13 13:01 PDT (History)
2 users (show)

See Also:


Attachments
Patch (24.76 KB, patch)
2015-05-12 14:25 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (24.76 KB, patch)
2015-05-12 16:30 PDT, Beth Dakin
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-05-12 14:08:14 PDT
Need SPI to set the overlay scroll bar style

rdar://problem/20143614
Comment 1 Beth Dakin 2015-05-12 14:25:34 PDT
Created attachment 252984 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-12 14:27:47 PDT
Attachment 252984 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:4472:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2015-05-12 15:21:56 PDT
Comment on attachment 252984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252984&action=review

> Source/WebCore/platform/ScrollTypes.h:167
>      enum ScrollbarOverlayStyle {
>          ScrollbarOverlayStyleDefault,
>          ScrollbarOverlayStyleDark,
> -        ScrollbarOverlayStyleLight
> +        ScrollbarOverlayStyleLight,
> +        ScrollbarOverlayStyleNone

I'm surprised this isn't OverlayScrollbarStyle? It's the style of the overlay scrollbar, not the overlay style of the scrollbar.

> Source/WebKit2/UIProcess/API/Cocoa/_WKOverlayScrollbarStyle.h:37
> +    _WKOverlayScrollbarStyleNone

Automatic?
Comment 4 Beth Dakin 2015-05-12 16:30:54 PDT
Created attachment 252997 [details]
Patch
Comment 5 Anders Carlsson 2015-05-13 12:19:14 PDT
Comment on attachment 252997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252997&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:5006
> +        parameters.scrollbarOverlayStyle = WTF::Optional<uint32_t>();

= Nullopt.
Comment 6 Beth Dakin 2015-05-13 12:30:07 PDT
Thank you! http://trac.webkit.org/changeset/184297
Comment 7 Beth Dakin 2015-05-13 13:01:48 PDT
Follow-up build fix: http://trac.webkit.org/changeset/184299