Bug 144927

Summary: Scroll snapping with padding in the container doesn't work
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2015-05-12 14:05:57 PDT
If you create a document with padding in the elements contained in the scroll-snap region, we get our calculations wrong and produce incorrect behavior.
Attachments
Patch (4.16 KB, patch)
2016-12-21 10:53 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-05-12 14:06:36 PDT
<rdar://problem/20923772>
Wenson Hsieh
Comment 2 2016-12-21 10:53:16 PST
Created attachment 297605 [details] Patch
Brent Fulgham
Comment 3 2016-12-21 11:59:58 PST
Comment on attachment 297605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297605&action=review Looks good, and EWS is happy. r=me. > LayoutTests/css3/scroll-snap/scroll-snap-children-with-padding-expected.txt:1 > +Scroll-snap offsets are: vertical = { 0, 10, 625, 1240, 1660, 2275, 2890, 2920 } I always get a little nervous about tests with specific pixel positions, since they can be flaky.
WebKit Commit Bot
Comment 4 2016-12-21 12:28:29 PST
Comment on attachment 297605 [details] Patch Clearing flags on attachment: 297605 Committed r210072: <http://trac.webkit.org/changeset/210072>
WebKit Commit Bot
Comment 5 2016-12-21 12:28:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.