Bug 144923

Summary: [Win] Activate SSE support for 32-bit builds
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Hyungwook Lee <hyungwook.lee>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, hyungwook.lee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2015-05-12 12:26:13 PDT
A while ago (in Bug 136959) we deactivated SSE instructions for 32-bit Windows builds so that certain older hardware could be supported. Now that we have dropped support for Windows XP and Windows Vista, there are far fewer supported Windows configurations that lack SSE support. We should turn SSE back on for our 32-bit Windows builds.
Attachments
Patch (1.20 KB, patch)
2015-06-29 07:37 PDT, Hyungwook Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-05-12 12:26:52 PDT
<rdar://problem/20921683>
Hyungwook Lee
Comment 2 2015-06-29 07:37:49 PDT
Created attachment 255748 [details] Patch
Brent Fulgham
Comment 3 2015-06-29 10:01:37 PDT
Comment on attachment 255748 [details] Patch This patch is correct. However, at one time we were trying to retain support for some older Intel CPUs that cannot support SSE instructions, which is why this was turned off. We may be able to reenable this now -- I'll check and report back.
Brent Fulgham
Comment 4 2015-06-29 15:19:08 PDT
Comment on attachment 255748 [details] Patch r=me! I've confirmed that we no longer support these old PC's so we can switch SSE on across the board.
WebKit Commit Bot
Comment 5 2015-06-29 16:09:16 PDT
Comment on attachment 255748 [details] Patch Clearing flags on attachment: 255748 Committed r186093: <http://trac.webkit.org/changeset/186093>
WebKit Commit Bot
Comment 6 2015-06-29 16:09:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.