Bug 144923 - [Win] Activate SSE support for 32-bit builds
Summary: [Win] Activate SSE support for 32-bit builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Hyungwook Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-12 12:26 PDT by Brent Fulgham
Modified: 2015-06-29 16:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2015-06-29 07:37 PDT, Hyungwook Lee 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-05-12 12:26:13 PDT 
A while ago (in Bug 136959) we deactivated SSE instructions for 32-bit Windows builds so that certain older hardware could be supported.

Now that we have dropped support for Windows XP and Windows Vista, there are far fewer supported Windows configurations that lack SSE support.

We should turn SSE back on for our 32-bit Windows builds.
Comment 1 Radar WebKit Bug Importer 2015-05-12 12:26:52 PDT 
<rdar://problem/20921683>
Comment 2 Hyungwook Lee 2015-06-29 07:37:49 PDT 
Created attachment 255748 [details]
Patch
Comment 3 Brent Fulgham 2015-06-29 10:01:37 PDT 
Comment on attachment 255748 [details]
Patch

This patch is correct. However, at one time we were trying to retain support for some older Intel CPUs that cannot support SSE instructions, which is why this was turned off. We may be able to reenable this now -- I'll check and report back.
Comment 4 Brent Fulgham 2015-06-29 15:19:08 PDT 
Comment on attachment 255748 [details]
Patch

r=me! I've confirmed that we no longer support these old PC's so we can switch SSE on across the board.
Comment 5 WebKit Commit Bot 2015-06-29 16:09:16 PDT 
Comment on attachment 255748 [details]
Patch

Clearing flags on attachment: 255748

Committed r186093: <http://trac.webkit.org/changeset/186093>
Comment 6 WebKit Commit Bot 2015-06-29 16:09:20 PDT 
All reviewed patches have been landed.  Closing bug.