Bug 144915
| Summary: | stress/int8-repeat-out-of-bounds.js and stress/float32-repeat-out-of-bounds.js fail with eager compilation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Basile Clement <basile_clement> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Minor | CC: | fpizlo, ggaren, mark.lam, msaboff |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Basile Clement
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Basile Clement
After looking at the test, this is probably a minor problem with the test making assumptions on the number of recompilations that is not correct with eager compilation.
Filip Pizlo
It's intentional. :-). The tests are asserting that we converge quickly and don't recompile too much. But with eager compilation, we will recompile more because we often don't get enough profiling in the first round. That's fine. I don't think we should try to make these tests pass in eager mode
Basile Clement
(In reply to comment #2)
> It's intentional. :-). The tests are asserting that we converge quickly and
> don't recompile too much. But with eager compilation, we will recompile more
> because we often don't get enough profiling in the first round. That's fine.
> I don't think we should try to make these tests pass in eager mode
OK, it just seemed weird that we had tests that would only succeed provided some options are within presupposed range, closing this then.