Bug 144901

Summary: Array.slice should have a fast path like Array.splice
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds a fast path none

Ryosuke Niwa
Reported 2015-05-11 22:50:50 PDT
Just memcopy stuff.
Attachments
Adds a fast path (4.32 KB, patch)
2015-05-11 22:53 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-05-11 22:53:23 PDT
Created attachment 252941 [details] Adds a fast path
Geoffrey Garen
Comment 2 2015-05-12 12:18:41 PDT
Comment on attachment 252941 [details] Adds a fast path r=me We should really implement these functions in JS.
Ryosuke Niwa
Comment 3 2015-05-12 13:15:42 PDT
Comment on attachment 252941 [details] Adds a fast path Thanks for the review. Let me see how implementing this in JS will turn out. But for now, we can land this for an incremental improvement.
WebKit Commit Bot
Comment 4 2015-05-12 14:05:37 PDT
Comment on attachment 252941 [details] Adds a fast path Clearing flags on attachment: 252941 Committed r184217: <http://trac.webkit.org/changeset/184217>
WebKit Commit Bot
Comment 5 2015-05-12 14:05:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.