Bug 144898

Summary:

AX: [EFL] Consider deferring to WebCore Accessibility for table exposure

Product:

WebKit

Reporter:

Joanmarie Diggs <jdiggs>

Component:

Accessibility

Assignee:

Joanmarie Diggs <jdiggs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
Patch	none

Description Joanmarie Diggs 2015-05-11 22:08:15 PDT

I suspect that the reason WebKitEfl exposes all tables (data and layout) as AccessibilityTables is because they inherited that expectation from WebKitGtk. As I indicated in bug 144896, there doesn't seem to be much point in continuing to override WebCore Accessibility -- at least not for WebKitGtk. If the only reason you do it in Efl is because we <strike>do</strike> did it in Gtk, it might be nice to get rid of this platform difference.

(BTW, I'd propose a patch myself but I'm having trouble at the moment building WebKitEfl. And the tests that spit out all attributes, including bounding boxes, are something one cannot take an educated guess at.)

Comment 1 Radar WebKit Bug Importer 2015-05-11 22:08:40 PDT

<rdar://problem/20911606>

Comment 2 Gyuyoung Kim 2015-12-07 13:42:07 PST

(In reply to comment #0)

> (BTW, I'd propose a patch myself but I'm having trouble at the moment
> building WebKitEfl. And the tests that spit out all attributes, including
> bounding boxes, are something one cannot take an educated guess at.)

I take a look the Bug 144896. First of all the updated expectations have been marked to *failure* in EFL port.

http://trac.webkit.org/browser/trunk/LayoutTests/platform/efl/TestExpectations#L1824

I'm not sure if EFL port needs to do something further yet. If you have patch for EFL port, please upload it to take a look.


> (BTW, I'd propose a patch myself but I'm having trouble at the moment building WebKitEfl.

Please following below instruction to build EFL port. Build step is similar to GTK port.

1. ./Tools/efl/install-dependencies
2. ./Tools/Scripts/build-webkit --efl --update-efl
3. ./Tools/Scripts/run-webkit-tests --efl test-path (e.g. fast/forms/plaintext-mode-1.html)

Comment 3 Joanmarie Diggs 2015-12-08 08:53:22 PST

Created attachment 266890 [details]
Patch

Comment 4 WebKit Commit Bot 2015-12-09 02:09:25 PST

Comment on attachment 266890 [details]
Patch

Clearing flags on attachment: 266890

Committed r193813: <http://trac.webkit.org/changeset/193813>

Comment 5 WebKit Commit Bot 2015-12-09 02:09:28 PST

All reviewed patches have been landed.  Closing bug.