Bug 144894

Summary: Limit alternate fullscreen with linked on or after.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, jonlee
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+
Patch for landing. none

Jeremy Jones
Reported 2015-05-11 20:30:55 PDT
Limit alternate fullscreen with linked on or after.
Attachments
Patch (2.92 KB, patch)
2015-05-11 20:35 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2015-05-14 10:24 PDT, Jeremy Jones 		dino: review+
DetailsFormatted DiffDiff
Patch for landing. (6.35 KB, patch)
2015-05-15 11:17 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2015-05-11 20:31:31 PDT
rdar://problem/20619179
Jeremy Jones
Comment 2 2015-05-11 20:35:40 PDT
Created attachment 252925 [details] Patch
Jeremy Jones
Comment 3 2015-05-14 10:24:52 PDT
Created attachment 253127 [details] Patch
Dean Jackson
Comment 4 2015-05-15 10:51:34 PDT
Comment on attachment 253127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253127&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:322 > + Nit: you added a blank line
Jeremy Jones
Comment 5 2015-05-15 11:17:25 PDT
Created attachment 253210 [details] Patch for landing.
Jeremy Jones
Comment 6 2015-05-15 11:17:55 PDT
(In reply to comment #4) > Comment on attachment 253127 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253127&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:322 > > + > > Nit: you added a blank line removed.
WebKit Commit Bot
Comment 7 2015-05-15 12:14:28 PDT
Comment on attachment 253210 [details] Patch for landing. Clearing flags on attachment: 253210 Committed r184404: <http://trac.webkit.org/changeset/184404>
Note You need to log in before you can comment on or make changes to this bug.