Bug 144894 - Limit alternate fullscreen with linked on or after.
Summary: Limit alternate fullscreen with linked on or after.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-11 20:30 PDT by Jeremy Jones
Modified: 2015-05-18 11:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2015-05-11 20:35 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (6.32 KB, patch)
2015-05-14 10:24 PDT, Jeremy Jones 		dino: review+
Details | Formatted Diff | Diff
Patch for landing. (6.35 KB, patch)
2015-05-15 11:17 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2015-05-11 20:30:55 PDT 
Limit alternate fullscreen with linked on or after.
Comment 1 Jeremy Jones 2015-05-11 20:31:31 PDT 
rdar://problem/20619179
Comment 2 Jeremy Jones 2015-05-11 20:35:40 PDT 
Created attachment 252925 [details]
Patch
Comment 3 Jeremy Jones 2015-05-14 10:24:52 PDT 
Created attachment 253127 [details]
Patch
Comment 4 Dean Jackson 2015-05-15 10:51:34 PDT 
Comment on attachment 253127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253127&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:322
> +

Nit: you added a blank line
Comment 5 Jeremy Jones 2015-05-15 11:17:25 PDT 
Created attachment 253210 [details]
Patch for landing.
Comment 6 Jeremy Jones 2015-05-15 11:17:55 PDT 
(In reply to comment #4)
> Comment on attachment 253127 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253127&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:322
> > +
> 
> Nit: you added a blank line

removed.
Comment 7 WebKit Commit Bot 2015-05-15 12:14:28 PDT 
Comment on attachment 253210 [details]
Patch for landing.

Clearing flags on attachment: 253210

Committed r184404: <http://trac.webkit.org/changeset/184404>