| Summary: | Show unparented tiles in the UI-side compositing tiled scrolling indicator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2015-05-11 15:46:25 PDT
Created attachment 252903 [details]
Patch
Comment on attachment 252903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252903&action=review > Source/WebCore/ChangeLog:20 > + to tell GraphicsLayerCA when the unparented tiles changed. extra space > Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.h:77 > + > + > + so many newlines > Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.mm:70 > + RetainPtr<CGColorSpaceRef> colorSpace = adoptCF(CGColorSpaceCreateDeviceRGB()); We have a shared one of these in GraphicsContextCG if you want to use it (lots of things do). > Source/WebKit2/UIProcess/Cocoa/RemoteLayerTreeTileMap.mm:78 > + RetainPtr<CALayer *> layer = adoptNS([[CALayer alloc] init]); No star needed. Checking with BugID on Webkit GitHub, it seems this r+ patch didn't landed. Do we need this anymore? Thanks! Yeah, still useful. |