Bug 144884

Summary: Simplify shim path computation
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2015-05-11 15:23:44 PDT 
Simplify shim path computation
Comment 1 Anders Carlsson 2015-05-11 15:25:51 PDT 
Created attachment 252896 [details]
Patch
Comment 2 Anders Carlsson 2015-05-11 15:33:03 PDT 
Committed r184125: <http://trac.webkit.org/changeset/184125>
Comment 3 Darin Adler 2015-05-11 18:11:19 PDT 
Comment on attachment 252896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252896&action=review

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:97
> +static RetainPtr<NSString> computeProcessShimPath(const ProcessLauncher::LaunchOptions& launchOptions, NSBundle *webKitBundle)

Why to just NSString * for the return value? Seems like all the code paths return something autoreleased.