| Summary: | [GTK] Reorder Performance class's member initialization sequence | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joonghun Park <jh718.park> | ||||
| Component: | WebCore Misc. | Assignee: | Joonghun Park <jh718.park> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, ggaren, gyuyoung.kim, kling, mrobinson, ossy, zan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 252841 [details]
Patch
Comment on attachment 252841 [details]
Patch
LGTM
Just to document, this bug was caused by http://trac.webkit.org/changeset/183795 Comment on attachment 252841 [details] Patch Clearing flags on attachment: 252841 Committed r184071: <http://trac.webkit.org/changeset/184071> All reviewed patches have been landed. Closing bug. |
To remove error as below, reorder Performance class member initialization sequence. In file included from ../../Source/WebCore/page/Performance.cpp:33:0: ../../Source/WebCore/page/Performance.h: In constructor ‘WebCore::Performance::Performance(WebCore::Frame*)’: ../../Source/WebCore/page/Performance.h:109:24: warning: ‘WebCore::Performance::m_userTiming’ will be initialized after [-Wreorder] RefPtr<UserTiming> m_userTiming; ^ ../../Source/WebCore/page/Performance.h:106:12: warning: ‘double WebCore::Performance::m_referenceTime’ [-Wreorder] double m_referenceTime; ^ ../../Source/WebCore/page/Performance.cpp:55:1: warning: when initialized here [-Wreorder] Performance::Performance(Frame* frame)