Bug 144858 - [GTK] Reorder Performance class's member initialization sequence
Summary: [GTK] Reorder Performance class's member initialization sequence
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joonghun Park
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-10 23:30 PDT by Joonghun Park
Modified: 2015-05-11 02:39 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2015-05-10 23:37 PDT, Joonghun Park 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joonghun Park 2015-05-10 23:30:28 PDT 
To remove error as below, reorder Performance class member initialization sequence.
In file included from ../../Source/WebCore/page/Performance.cpp:33:0:
../../Source/WebCore/page/Performance.h: In constructor ‘WebCore::Performance::Performance(WebCore::Frame*)’:
../../Source/WebCore/page/Performance.h:109:24: warning: ‘WebCore::Performance::m_userTiming’ will be initialized after [-Wreorder]
     RefPtr<UserTiming> m_userTiming;
                        ^
../../Source/WebCore/page/Performance.h:106:12: warning:   ‘double WebCore::Performance::m_referenceTime’ [-Wreorder]
     double m_referenceTime;
            ^
../../Source/WebCore/page/Performance.cpp:55:1: warning:   when initialized here [-Wreorder]
 Performance::Performance(Frame* frame)
Comment 1 Joonghun Park 2015-05-10 23:37:45 PDT 
Created attachment 252841 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-05-11 01:53:37 PDT 
Comment on attachment 252841 [details]
Patch

LGTM
Comment 3 Csaba Osztrogonác 2015-05-11 01:55:17 PDT 
Just to document, this bug was caused by http://trac.webkit.org/changeset/183795
Comment 4 WebKit Commit Bot 2015-05-11 02:39:50 PDT 
Comment on attachment 252841 [details]
Patch

Clearing flags on attachment: 252841

Committed r184071: <http://trac.webkit.org/changeset/184071>
Comment 5 WebKit Commit Bot 2015-05-11 02:39:54 PDT 
All reviewed patches have been landed.  Closing bug.