RESOLVED FIXED144858
[GTK] Reorder Performance class's member initialization sequence 
https://bugs.webkit.org/show_bug.cgi?id=144858
Summary [GTK] Reorder Performance class's member initialization sequence
Joonghun Park
Reported 2015-05-10 23:30:28 PDT
To remove error as below, reorder Performance class member initialization sequence. In file included from ../../Source/WebCore/page/Performance.cpp:33:0: ../../Source/WebCore/page/Performance.h: In constructor ‘WebCore::Performance::Performance(WebCore::Frame*)’: ../../Source/WebCore/page/Performance.h:109:24: warning: ‘WebCore::Performance::m_userTiming’ will be initialized after [-Wreorder] RefPtr<UserTiming> m_userTiming; ^ ../../Source/WebCore/page/Performance.h:106:12: warning: ‘double WebCore::Performance::m_referenceTime’ [-Wreorder] double m_referenceTime; ^ ../../Source/WebCore/page/Performance.cpp:55:1: warning: when initialized here [-Wreorder] Performance::Performance(Frame* frame)
Attachments
Patch (1.44 KB, patch)
2015-05-10 23:37 PDT, Joonghun Park 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joonghun Park
Comment 1 2015-05-10 23:37:45 PDT
Created attachment 252841 [details] Patch
Csaba Osztrogonác
Comment 2 2015-05-11 01:53:37 PDT
Comment on attachment 252841 [details] Patch LGTM
Csaba Osztrogonác
Comment 3 2015-05-11 01:55:17 PDT
Just to document, this bug was caused by http://trac.webkit.org/changeset/183795
WebKit Commit Bot
Comment 4 2015-05-11 02:39:50 PDT
Comment on attachment 252841 [details] Patch Clearing flags on attachment: 252841 Committed r184071: <http://trac.webkit.org/changeset/184071>
WebKit Commit Bot
Comment 5 2015-05-11 02:39:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.