Bug 144851

Summary: We shouldn't promote LoadVarargs to a sequence of GetStacks and PutStacks if doing so would exceed the LoadVarargs' limit
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
msaboff: review-
the patch msaboff: review+

Description Filip Pizlo 2015-05-10 17:43:14 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-05-10 17:55:09 PDT 
Created attachment 252833 [details]
the patch
Comment 2 Michael Saboff 2015-05-11 09:02:35 PDT 
Comment on attachment 252833 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252833&action=review

Break out the new forceEagerCompilation option into a separate patch.
After that I'll r+ both patches.

> Source/JavaScriptCore/ChangeLog:29
> +        compilation, and then running layout tests tests with this mode.

Duplicate "tests"
Comment 3 Filip Pizlo 2015-05-11 10:58:20 PDT 
Created attachment 252867 [details]
the patch
Comment 4 Michael Saboff 2015-05-11 11:02:39 PDT 
Comment on attachment 252867 [details]
the patch

r=me
Comment 5 Filip Pizlo 2015-05-11 11:19:48 PDT 
Landed in http://trac.webkit.org/changeset/184110