Bug 144851 - We shouldn't promote LoadVarargs to a sequence of GetStacks and PutStacks if doing so would exceed the LoadVarargs' limit
Summary: We shouldn't promote LoadVarargs to a sequence of GetStacks and PutStacks if ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-10 17:43 PDT by Filip Pizlo
Modified: 2015-05-11 11:19 PDT (History)
11 users (show)

See Also:


Attachments
the patch (11.73 KB, patch)
2015-05-10 17:55 PDT, Filip Pizlo
msaboff: review-
Details | Formatted Diff | Diff
the patch (9.86 KB, patch)
2015-05-11 10:58 PDT, Filip Pizlo
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-05-10 17:43:14 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-05-10 17:55:09 PDT
Created attachment 252833 [details]
the patch
Comment 2 Michael Saboff 2015-05-11 09:02:35 PDT
Comment on attachment 252833 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252833&action=review

Break out the new forceEagerCompilation option into a separate patch.
After that I'll r+ both patches.

> Source/JavaScriptCore/ChangeLog:29
> +        compilation, and then running layout tests tests with this mode.

Duplicate "tests"
Comment 3 Filip Pizlo 2015-05-11 10:58:20 PDT
Created attachment 252867 [details]
the patch
Comment 4 Michael Saboff 2015-05-11 11:02:39 PDT
Comment on attachment 252867 [details]
the patch

r=me
Comment 5 Filip Pizlo 2015-05-11 11:19:48 PDT
Landed in http://trac.webkit.org/changeset/184110