Bug 144797

Summary: Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTransformOperation
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 144876    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2015-05-08 02:50:52 PDT
Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTransformOperation
Attachments
Patch (4.75 KB, patch)
2015-05-08 02:57 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.24 KB, patch)
2015-05-12 03:14 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-05-08 02:57:44 PDT
Created attachment 252715 [details] Patch
Darin Adler
Comment 2 2015-05-10 14:56:54 PDT
Comment on attachment 252715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252715&action=review > Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.cpp:38 > +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress) New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>. > Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.cpp:37 > +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress) New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>.
Zan Dobersek
Comment 3 2015-05-11 11:20:04 PDT
Uploaded a patch for PassRefPtr removal in the TransformOperation hierarchy in bug #144876.
Zan Dobersek
Comment 4 2015-05-12 03:14:18 PDT
Created attachment 252952 [details] Patch for landing
Zan Dobersek
Comment 5 2015-05-12 23:48:46 PDT
Comment on attachment 252952 [details] Patch for landing Clearing flags on attachment: 252952 Committed r184274: <http://trac.webkit.org/changeset/184274>
Zan Dobersek
Comment 6 2015-05-12 23:48:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.