| Summary: | Reduce TransformationMatrix copies in MatrixTransformOperation, Matrix3DTransformOperation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 144876 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2015-05-08 02:50:52 PDT
Created attachment 252715 [details]
Patch
Comment on attachment 252715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252715&action=review > Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.cpp:38 > +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress) New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>. > Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.cpp:37 > +static PassRefPtr<TransformOperation> createOperation(TransformationMatrix& to, TransformationMatrix& from, double progress) New functions should not return PassRefPtr. See <http://www.webkit.org/coding/RefPtr.html>. This function should return Ref<TransformOperation>. Uploaded a patch for PassRefPtr removal in the TransformOperation hierarchy in bug #144876. Created attachment 252952 [details]
Patch for landing
Comment on attachment 252952 [details] Patch for landing Clearing flags on attachment: 252952 Committed r184274: <http://trac.webkit.org/changeset/184274> All reviewed patches have been landed. Closing bug. |