Bug 144781 – [Content Extensions] Add simple tester that takes an extension and compiles it

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

[Content Extensions] Add simple tester that takes an extension and compiles it

[Sam Weinig]

Created attachment 252675 [details]
Patch

[WebKit Commit Bot]

Attachment 252675 [details] did not pass style-queue:


ERROR: Tools/ContentExtensionTester/main.m:49:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Comment on attachment 252675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252675&action=review

This looks sane to me.

> Tools/ContentExtensionTester/main.m:29
> +static void run(bool* done)

Minor: '*' should be on the right.

> Tools/ContentExtensionTester/main.m:35
> +int main(int argc, const char * argv[])

Ditto.

> Tools/Scripts/run-content-extension-tester:1
> +#!/usr/bin/perl -w

I am assuming that since this file was created from an svn copy of Tools/Scripts/run-webkit-test that SVN will be smart enough t copy the executable bit from the original file given the absence of a property change diff in this patch to explicitly set the executable bit on this file.

[Sam Weinig]

Committed revision 184033.