RESOLVED FIXED 144781
[Content Extensions] Add simple tester that takes an extension and compiles it 
https://bugs.webkit.org/show_bug.cgi?id=144781
Summary [Content Extensions] Add simple tester that takes an extension and compiles it
Sam Weinig
Reported 2015-05-07 19:26:52 PDT
[Content Extensions] Add simple tester that takes an extension and compiles it
Attachments
Patch (34.46 KB, patch)
2015-05-07 19:27 PDT, Sam Weinig 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2015-05-07 19:27:42 PDT
Created attachment 252675 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-07 19:30:21 PDT
Attachment 252675 [details] did not pass style-queue: ERROR: Tools/ContentExtensionTester/main.m:49: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 3 2015-05-08 11:46:01 PDT
Comment on attachment 252675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252675&action=review This looks sane to me. > Tools/ContentExtensionTester/main.m:29 > +static void run(bool* done) Minor: '*' should be on the right. > Tools/ContentExtensionTester/main.m:35 > +int main(int argc, const char * argv[]) Ditto. > Tools/Scripts/run-content-extension-tester:1 > +#!/usr/bin/perl -w I am assuming that since this file was created from an svn copy of Tools/Scripts/run-webkit-test that SVN will be smart enough t copy the executable bit from the original file given the absence of a property change diff in this patch to explicitly set the executable bit on this file.
Sam Weinig
Comment 4 2015-05-08 17:35:04 PDT
Committed revision 184033.
Note You need to log in before you can comment on or make changes to this bug.