Bug 144781 - [Content Extensions] Add simple tester that takes an extension and compiles it
Summary: [Content Extensions] Add simple tester that takes an extension and compiles it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-07 19:26 PDT by Sam Weinig
Modified: 2015-05-08 17:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (34.46 KB, patch)
2015-05-07 19:27 PDT, Sam Weinig 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-05-07 19:26:52 PDT 
[Content Extensions] Add simple tester that takes an extension and compiles it
Comment 1 Sam Weinig 2015-05-07 19:27:42 PDT 
Created attachment 252675 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-07 19:30:21 PDT 
Attachment 252675 [details] did not pass style-queue:


ERROR: Tools/ContentExtensionTester/main.m:49:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daniel Bates 2015-05-08 11:46:01 PDT 
Comment on attachment 252675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252675&action=review

This looks sane to me.

> Tools/ContentExtensionTester/main.m:29
> +static void run(bool* done)

Minor: '*' should be on the right.

> Tools/ContentExtensionTester/main.m:35
> +int main(int argc, const char * argv[])

Ditto.

> Tools/Scripts/run-content-extension-tester:1
> +#!/usr/bin/perl -w

I am assuming that since this file was created from an svn copy of Tools/Scripts/run-webkit-test that SVN will be smart enough t copy the executable bit from the original file given the absence of a property change diff in this patch to explicitly set the executable bit on this file.
Comment 4 Sam Weinig 2015-05-08 17:35:04 PDT 
Committed revision 184033.