Bug 144778

Summary: REGRESSION (r183300): Fixed elements flash when scrolling
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Description Simon Fraser (smfr) 2015-05-07 18:15:00 PDT
REGRESSION (r183300): Fixed elements flash when scrolling
Comment 1 Simon Fraser (smfr) 2015-05-07 18:31:29 PDT
Created attachment 252671 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-05-07 18:31:57 PDT
rdar://problem/20769741
Comment 3 Dean Jackson 2015-05-07 18:46:04 PDT
Comment on attachment 252671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252671&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:153
> -        bool ancestorHasTransformAnimation;
> -        int treeDepth;
> -        CommitState()
> -            : ancestorHasTransformAnimation(false)
> -            , treeDepth(0)
> -        { }
> +        int treeDepth { 0 };
> +        bool ancestorHasTransformAnimation { false };
> +        bool ancestorsAllowBackingStoreDetachment { true };

Nice!
Comment 4 Simon Fraser (smfr) 2015-05-07 18:48:44 PDT
https://trac.webkit.org/r183970
Comment 5 Chris Dumez 2015-05-07 23:05:23 PDT
Follow-up build fix in <http://trac.webkit.org/changeset/183980> for:
"""
ERROR: WebCore has a weak external symbol in it (/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol __ZNK7WebCore15GraphicsLayerCA28allowsBackingStoreDetachmentEv
Command /bin/sh failed with exit code 1
"""
Comment 6 Simon Fraser (smfr) 2015-05-07 23:42:16 PDT
Thanks for the build fix, Chris.