Bug 144775

Summary:

Avoid always running some debug code in type profiling

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

JavaScriptCore

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

joepeck, saam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	dbates: review+

Description Joseph Pecoraro 2015-05-07 17:12:52 PDT

* SUMMARY
Avoid always running some debug code in type profiling.

There is a currentTimeMS call only used by debugging code. Avoid it in the common case.

Comment 1 Joseph Pecoraro 2015-05-07 17:14:03 PDT

Created attachment 252657 [details]
[PATCH] Proposed Fix

Patch won't apply, because it sits on top of another patch.

Comment 2 Saam Barati 2015-05-07 18:21:13 PDT

Comment on attachment 252657 [details]
[PATCH] Proposed Fix

Looks good to me.

Comment 3 Daniel Bates 2015-05-07 23:59:03 PDT

Comment on attachment 252657 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=252657&action=review

> Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:57
> +    double before = 0;

Maybe a better name for this variable would be beginTime. Similarly, maybe a better name for the local variable after would be endTime.

Comment 4 Joseph Pecoraro 2015-05-13 11:53:45 PDT

http://trac.webkit.org/changeset/184292