Bug 144760

Summary: Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, dbates, esprehn+autocc, kangil.han, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Tim Horton
Reported 2015-05-07 14:26:19 PDT
Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites
Attachments
Patch (11.86 KB, patch)
2015-05-07 14:26 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (10.87 KB, patch)
2015-05-07 16:29 PDT, Tim Horton 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-05-07 14:26:44 PDT
Created attachment 252628 [details] Patch
Tim Horton
Comment 2 2015-05-07 15:15:33 PDT
Comment on attachment 252628 [details] Patch Going in a different direction with this.
Tim Horton
Comment 3 2015-05-07 16:29:05 PDT
Created attachment 252645 [details] Patch
Darin Adler
Comment 4 2015-05-10 15:20:57 PDT
Comment on attachment 252645 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252645&action=review > Source/WebCore/dom/ViewportArguments.cpp:398 > // FIXME: Ignore silently for now. This should eventually fallback to the warning. the verb fall back is two words > Source/WebCore/dom/ViewportArguments.h:91 > + , shrinkToFit(ValueAuto) Should initialize below instead of here in the constructor (now that we can). > Source/WebCore/dom/ViewportArguments.h:109 > + float shrinkToFit; I don’t get why this is a float. > Source/WebCore/page/ViewportConfiguration.cpp:306 > + if (booleanViewportArgumentIsSet(m_viewportArguments.userZoom)) > m_configuration.allowsUserScaling = m_viewportArguments.userZoom != 0.; Strange to use a function for one thing and inline code for the other. Also the use of != 0. here is strangely different from what booleanViewportArgumentIsSet does.
Tim Horton
Comment 5 2015-05-20 13:43:30 PDT
http://trac.webkit.org/changeset/184654
Radar WebKit Bug Importer
Comment 6 2015-05-20 13:44:47 PDT
<rdar://problem/21044514>
Note You need to log in before you can comment on or make changes to this bug.