Summary: | [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, svillar | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2015-05-07 09:34:58 PDT
Created attachment 252594 [details]
Patch
Comment on attachment 252594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252594&action=review That's a r=me. Another WebKitGtk reviewer must approve the new API though > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060 > + if (currentValue == allowed) currentValue is not really needed. I think using the function call directly is explicit enough. (In reply to comment #2) > Comment on attachment 252594 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252594&action=review > > That's a r=me. Another WebKitGtk reviewer must approve the new API though Thanks!, you can safely r+, cq- I won't land it until I get the second approval. > > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3060 > > + if (currentValue == allowed) > > currentValue is not really needed. I think using the function call directly > is explicit enough. Yes, we have that pattern in the whole file, I don't remember if there was a reason, or we just copy-pasted every time :-) Comment on attachment 252594 [details]
Patch
Yep, makes sense to me =)
Committed r183992: <http://trac.webkit.org/changeset/183992> |