[EFL] REGRESSION(r183907): It made all inspector-protocol test crash

• Component: New Bugs
• Status: RESOLVED WONTFIX

[Csaba Osztrogonác]

before: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21710
after: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21711

crash log for inspector-protocol/console/console-message.html:

crash log for WebKitTestRunner (pid 13663):

Coredump core-pid_13663-_-process_WebKitTestRunner not found. To enable crash logs:

- run this command as super-user: echo "/path/to/coredumps/core-pid_%p-_-process_%E" > /proc/sys/kernel/core_pattern
- enable core dumps: ulimit -c unlimited
- set the WEBKIT_CORE_DUMPS_DIRECTORY environment variable: export WEBKIT_CORE_DUMPS_DIRECTORY=/path/to/coredumps


STDERR: 1   0x7fbf48d13ff8
STDERR: 2   0x7fbf4456bd40
STDERR: 3   0x7fbf46bbf7b0 WebKit::WebInspectorProxy::attachAvailabilityChanged(bool)
STDERR: 4   0x7fbf46d6667b WebKit::WebInspectorProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)
STDERR: 5   0x7fbf46b27d5a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&)
STDERR: 6   0x7fbf46bf31d2 WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)
STDERR: 7   0x7fbf46b2602b IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >)
STDERR: 8   0x7fbf46b26a63 IPC::Connection::dispatchOneMessage()
STDERR: 9   0x7fbf47e21063 WTF::RunLoop::performWork()
STDERR: 10  0x7fbf456e0e1f
STDERR: 11  0x7fbf456e15be
STDERR: 12  0x7fbf456e0369
STDERR: 13  0x7fbf456e04d5 ecore_main_loop_iterate
STDERR: 14  0x41eaa5 WTR::TestController::platformRunUntil(bool&, double)
STDERR: 15  0x419bcc WTR::TestInvocation::invoke()
STDERR: 16  0x4115d6 WTR::TestController::runTest(char const*)
STDERR: 17  0x41176b WTR::TestController::runTestingServerLoop()
STDERR: 18  0x418808 WTR::TestController::TestController(int, char const**)
STDERR: 19  0x40cd08 main
STDERR: 20  0x7fbf44556ec5 __libc_start_main
STDERR: 21  0x40cd4c
STDERR: Error receiving IPC message on socket 25 in process 13682: Connection reset by peer

[Csaba Osztrogonác]

The EFL bot exited early due to this bug, so we can't catch any 
new regression now. I skipped inspector-protocol tests on EFL
to make it a little bit happier - https://trac.webkit.org/changeset/183923
(I had to comment out existing inspector-protocol expectations
to avoid ambiguous expectations. This comments should be removed
once this bug is fixed.)

I won't have time in the near future to work on this bug, so feel 
free to pick it up if you are interested in working inspector on EFL.
And please unskip the tests with the proper fix in the same patch.

[Joseph Pecoraro]

(In reply to comment #0)
> STDERR: 1   0x7fbf48d13ff8
> STDERR: 2   0x7fbf4456bd40
> STDERR: 3   0x7fbf46bbf7b0
> WebKit::WebInspectorProxy::attachAvailabilityChanged(bool)
> STDERR: 4   0x7fbf46d6667b
> WebKit::WebInspectorProxy::didReceiveMessage(IPC::Connection&,
> IPC::MessageDecoder&)

Err, sorry for the breakage. Those top two frames are mysterious, are there normally unnamed frames in crash logs, and if so what might they mean?

The added code in WebInspectorProxy::attachAvailabilityChanged was:

>    if (!m_underTest) 
>        m_inspectorPage->process().send(Messages::WebInspectorUI::SetDockingUnavailable(!m_canAttach), m_inspectorPage->pageID()); 

I would expect m_inspectorPage to be valid, but I don't see us crashing otherwise =(.

[Joseph Pecoraro]

Are you still seeing this? Currently EFL Skips all inspector tests =(

[Csaba Osztrogonác]

cc-ing EFL guys, I don't have time to investigate/validate this bug nowadays

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.