Summary: | Fix <script srcset> being loaded by the preloader. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoav Weiss <yoav> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, commit-queue, dino, esprehn+autocc, gyuyoung.kim | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Yoav Weiss
2015-05-06 00:36:24 PDT
Created attachment 252458 [details]
Patch
Created attachment 252460 [details]
Patch
A preloadScanner bug with srcset I found while going over the code is that it would download <script srcset> for no good reason. This patch fixes that. Comment on attachment 252460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252460&action=review > LayoutTests/http/tests/loading/preload-script-src-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should see the script resource. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-script-src.html:9 > +This test needs to be run in DRT. Preload scanner should see the script resource. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner. > LayoutTests/http/tests/loading/preload-script-srcset-ignored-expected.txt:6 > +This test needs to be run in DRT. Preload scanner should not see the script resource since it's in a srcset attribute. It’s not so good to have this in the test output. We should make this visible only when you are not running it in the test runner. > LayoutTests/http/tests/loading/preload-script-srcset-ignored.html:9 > +This test needs to be run in DRT. Preload scanner should not see the script resource since it's in a srcset attribute. It’s not great to refer to the test runner as DRT. The latest version is named WebKitTestRunner. Created attachment 252577 [details]
Patch
Comment on attachment 252577 [details] Patch Clearing flags on attachment: 252577 Committed r183920: <http://trac.webkit.org/changeset/183920> All reviewed patches have been landed. Closing bug. |