| Summary: | REGRESSION (r183517): Yellow find-in-page highlight gets stuck forever | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, dino, ggaren, mitz, ossy, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2015-05-05 17:50:50 PDT
Created attachment 252426 [details]
Patch
Comment on attachment 252426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252426&action=review > Source/WebCore/ChangeLog:5 > + <rdar://problem/20755722> > + https://bugs.webkit.org/show_bug.cgi?id=144651 These are backwards. Comment on attachment 252426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252426&action=review > Source/WebCore/page/mac/TextIndicatorWindow.mm:85 > +@property (nonatomic) BOOL fadingOut; getter=isFadingOut. Properties normally come before instance methods. > Source/WebCore/page/mac/TextIndicatorWindow.mm:374 > + if ([m_textIndicatorView fadingOut]) isFadingOut] > Source/WebCore/page/mac/TextIndicatorWindow.mm:431 > + if ([m_textIndicatorView fadingOut]) Ditto. (In reply to comment #5) > Thanks! > > http://trac.webkit.org/changeset/183859 It broke the build on the 32 bit Apple Yosemite bot: https://build.webkit.org/builders/Apple%20Yosemite%20Release%20%2832-bit%20Build%29/builds/2817 Just to document, it was fixed by https://trac.webkit.org/changeset/183870 |