Bug 144596

Summary:

Add a WKView SPI to get the window used for taking back/forward snapshots

Product:

WebKit

Reporter:

Ada Chan <adachan>

Component:

WebKit2

Assignee:

Ada Chan <adachan>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ada Chan 2015-05-04 14:24:21 PDT

Add a WKView SPI to get the window used for taking back/forward snapshots.  

Proposed signature of that SPI is:
- (NSWindow *)_windowForTakingSnapshot;

This is needed for <rdar://problem/20681226>

Comment 1 Ada Chan 2015-05-04 15:02:43 PDT

Created attachment 252337 [details]
Patch

Comment 2 Tim Horton 2015-05-04 15:11:11 PDT

Comment on attachment 252337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252337&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3374
> +    NSWindow *window = self._windowForTakingSnapshot;

How does the

    windowCaptureRect = [self convertRect:unobscuredBounds toView:nil];

below deal with this?

Comment 3 Ada Chan 2015-05-04 16:17:52 PDT

We'll try to accomplish what we need without this change.  Closing the bug.

Comment 4 Daniel Bates 2015-05-05 20:56:42 PDT

Comment on attachment 252337 [details]
Patch

Clearing review flag to remove this patch from the review queue.