Bug 144596

Summary: Add a WKView SPI to get the window used for taking back/forward snapshots
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED WONTFIX    
Severity: Normal CC: thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ada Chan
Reported 2015-05-04 14:24:21 PDT
Add a WKView SPI to get the window used for taking back/forward snapshots. Proposed signature of that SPI is: - (NSWindow *)_windowForTakingSnapshot; This is needed for <rdar://problem/20681226>
Attachments
Patch (2.79 KB, patch)
2015-05-04 15:02 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2015-05-04 15:02:43 PDT
Created attachment 252337 [details] Patch
Tim Horton
Comment 2 2015-05-04 15:11:11 PDT
Comment on attachment 252337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252337&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:3374 > + NSWindow *window = self._windowForTakingSnapshot; How does the windowCaptureRect = [self convertRect:unobscuredBounds toView:nil]; below deal with this?
Ada Chan
Comment 3 2015-05-04 16:17:52 PDT
We'll try to accomplish what we need without this change. Closing the bug.
Daniel Bates
Comment 4 2015-05-05 20:56:42 PDT
Comment on attachment 252337 [details] Patch Clearing review flag to remove this patch from the review queue.
Note You need to log in before you can comment on or make changes to this bug.