Bug 144591

Summary:

Add overflow and iframe scroll-snap tests

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Tools / Tests

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=142358

Bug Depends on:

144482

Bug Blocks:

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Brent Fulgham 2015-05-04 12:48:13 PDT

The existing handfull of scroll-snap tests are focused on main frame (fast scrolling) scroll-snap points. We need to make sure that the overflow scroll-snap feature does not regress.

Comment 1 Brent Fulgham 2015-05-05 09:49:39 PDT

Created attachment 252387 [details]
Patch

Comment 2 Brent Fulgham 2015-05-05 09:52:28 PDT

This patch also includes iframe scroll tests.

Comment 3 Simon Fraser (smfr) 2015-05-05 10:23:14 PDT

Comment on attachment 252387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252387&action=review

> LayoutTests/ChangeLog:16
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources/horizontal-mainframe.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources/vertical-mainframe.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up-expected.txt: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe-expected.txt: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-expected.txt: Added.
> +        * platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html: Added.

It would be nice to have some WK1-main frame scroll and overflow-scrolling tests too.

> LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html:26
> +        function locationInWindowCoordinates(element) {

Normal JS convention is brace on new line (like C++).

Comment 4 Brent Fulgham 2015-05-05 13:12:14 PDT

(In reply to comment #3)
> It would be nice to have some WK1-main frame scroll and overflow-scrolling
> tests too.

Will do!

> > LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html:26
> > +        function locationInWindowCoordinates(element) {
> 
> Normal JS convention is brace on new line (like C++).

Fixed.

Comment 5 Brent Fulgham 2015-05-05 13:13:27 PDT

Committed r183823: <http://trac.webkit.org/changeset/183823>