Summary: | REGRESSION (r178156): CSS Parser incorrectly rejects valid calc() in padding-right property | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin, jonlee, kling, koivisto | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2015-05-04 10:09:32 PDT
Created attachment 252322 [details]
Patch
Comment on attachment 252322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252322&action=review > Source/WebCore/css/CSSParser.cpp:-1678 > - if (isValid && mustBeNonNegative && calculation->isNegative()) Are there any call sites calling CSSCalcValue::isNegative after this change? If so, what for? (In reply to comment #2) > Comment on attachment 252322 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=252322&action=review > > > Source/WebCore/css/CSSParser.cpp:-1678 > > - if (isValid && mustBeNonNegative && calculation->isNegative()) > > Are there any call sites calling CSSCalcValue::isNegative after this change? > If so, what for? No, it is no longer used. I will drop the method. Created attachment 252328 [details]
Patch
Comment on attachment 252328 [details] Patch Clearing flags on attachment: 252328 Committed r183765: <http://trac.webkit.org/changeset/183765> All reviewed patches have been landed. Closing bug. |