Bug 144584 – REGRESSION (r178156): CSS Parser incorrectly rejects valid calc() in padding-right property

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

After <http://trac.webkit.org/changeset/178156>, the CSS Parser sometimes rejects valid CSS calculations for CSS properties whose value cannot be negative (e.g. padding-right) because it thinks the calculation is negative.

Radar: <rdar://problem/20796829>

[Chris Dumez]

Created attachment 252322 [details]
Patch

[Darin Adler]

Comment on attachment 252322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252322&action=review

> Source/WebCore/css/CSSParser.cpp:-1678
> -        if (isValid && mustBeNonNegative && calculation->isNegative())

Are there any call sites calling CSSCalcValue::isNegative after this change? If so, what for?

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 252322 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252322&action=review
> 
> > Source/WebCore/css/CSSParser.cpp:-1678
> > -        if (isValid && mustBeNonNegative && calculation->isNegative())
> 
> Are there any call sites calling CSSCalcValue::isNegative after this change?
> If so, what for?

No, it is no longer used. I will drop the method.

[Chris Dumez]

Created attachment 252328 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 252328 [details]
Patch

Clearing flags on attachment: 252328

Committed r183765: <http://trac.webkit.org/changeset/183765>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.